fix: GeneratorCompilerPass for ThumbnailService#164
Merged
tinect merged 3 commits intoFriendsOfShopware:mainfrom Aug 8, 2025
gecolay:fix-missing-media-thumbnail-size-id
Merged
fix: GeneratorCompilerPass for ThumbnailService#164tinect merged 3 commits intoFriendsOfShopware:mainfrom gecolay:fix-missing-media-thumbnail-size-id
tinect merged 3 commits intoFriendsOfShopware:mainfrom
gecolay:fix-missing-media-thumbnail-size-id
Conversation
Contributor
Author
|
@tinect This should fix #163 and fix shopware/shopware#11760 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
============================================
- Coverage 75.00% 73.89% -1.11%
- Complexity 160 163 +3
============================================
Files 14 14
Lines 468 475 +7
============================================
Hits 351 351
- Misses 117 124 +7
🚀 New features to boost your workflow:
|
7 tasks
Member
|
Many thanks @gecolay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with the latest trunk changes while still being backwards compatible with all old Shopware versions.
Fix Not compatible with trunk #163